Skip to content

Jackyf/refactor news merge (?)#593

Open
innocentoak wants to merge 15 commits into
mainfrom
jackyf/refactor-news
Open

Jackyf/refactor news merge (?)#593
innocentoak wants to merge 15 commits into
mainfrom
jackyf/refactor-news

Conversation

@innocentoak
Copy link
Copy Markdown
Member

Maybe just review the files I nuked to see if there is dependencies on them elsewhere in the app.

From what I've seen the app still compiles and runs like normal, and even more files could possibly be nuked.

1) ExternalNewsView replaces NewsViewController (3 segmented news view)
2) NewsWebView is used in ExternalNewsView to have the individual WebViews for each tab of the segmented control
3) NewsDetailView replaces NativeViewController in having new styling that replicates that of NY Times and Washington Post
4) Removes old reference to NewsArticle model
…o its own file for sake of collating all relevant News files
…ewsDetailView, and also reference to NewsCardView that is now in its own separate file
…troller again) and add the navigation to it from Features
1) HomeNewsCell
2) HomeNewsCEllItem
3) NativeNewsViewController
…p still compiles

1) HomePostCell
2) HomePostCellItem
3) HomeViewController + Delegates
4) HomeItemTypes
5) ControllerModel
…from the nuke

1) HomePostCell
2) HomePostCellitem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant